Greasy Fork镜像

"Actions" > "Minions" ignores "Cancel battle" setting. Always cancels failed minion battles and breaks consistency between server/client.

When a minion battle fails while using the "Actions" > "Minions" menu, HWH tries to automatically cancel the battle if it is a loss, even if the "Cancel battle" setting is not selected. There is no log entry for the battle, and the client shows 1, sometimes 2 moves remaining, but the minion battle is marked as having been fought and the move cannot be used to reattempt the battle.

This seemed to be fixed; however, in 2.340 the bug has returned. One lost minion battle. "Morale Points" log shows 7 fights used. Minion attack attempts remaining: 2. Private "Minion log" shows logs for 8 nodes fought. Asgard minion fight menu shows 9 check marks. Settings: Cancel battle: False.

Cancellations work fine there, sometimes there are such errors, but the reason for them is not entirely clear and I can't reproduce them.
Regarding the first message, do you think it would be better to lose the battle if cancellations are disabled?

Is too frequent battle cancellation (via client/server inconsistency error?) a good way to detect unauthorized 3rd party tool? We warn about doing so in GW and CoW for that reason. Then losing when Cancel Battle = False is probably best. It also leads to less issues with client/server inconsistency. It is always the same battle, so I wish I could skip it on Actions -> Minions and fight it manually or purchase some buffs before skipping it on Auto.

On the same day, two different servers on the same browser, the same Asgard minion fight was lost. One cancelled properly, but the other had inconsistency. The server thinks that the battle had an error, but somehow one move was not used and an extra was returned, for two moves unused. The battle is not in the log, but somehow the server thinks that the battle was fought. Personal data says 8 battles fought, but guild data says 7 battles. It must be that the server is not processing the cancellation properly, but why? Timing issue? A new minion battle is started too soon after the canceled minion battle? Or did HWH try to fight the battle twice and lose both?

yes, I know how it looks, but I don't know in what specific cases it happens, my accounts don't have such a problem and cancellations always work correctly, if you have any useful information on how to 100% reproduce this problem, I will probably try to study it and fix it
In GW and CoW, the ability to cancel battles from the server side has long been fixed if they haven't done it in other modes, then there is no need for it

Regarding the first message, do you think it would be better to lose the battle if cancellations are disabled?

No, I think it's best to keep things as they currently are, it makes a lot of sense this way. Adding extra conditions will only confuse users who are used to doing things that work PERFECTLY well. The current system is very convenient, and modifying it to suit a few fringe cases just because they show up in the feedback system isn't a good idea.

In feedback systems like this, people will rarely post positive feedback if everything works great, but complain as soon as they find something broken. The rule of thumb is something like a 12:1 ratio. That is, for every 1 complaint that's posted, there are something like 12 users who're perfectly happy but don't post.

So unless you get a large number of complaints about this, it's probably better to keep the setting unchanged.