Greasy Fork镜像

Not working

Not working.

@pearlheartgtr said: Not working.

Can't seem to find a problem except a tiny correction i just made. See if it works.

Ah yes, forgot to tell you, it's not perfect yet based on some gif images hosted on giphy and such not providing a direct media url. Will do add some checks for that after some time.

Unfortunately not working.

@despecial said: Unfortunately not working.

Only way i can think of fixing this: Right-click, press Q, choose "console" tab and send me any red-colored errors. edit: could it be - the button is showing but the result of clicking it is not an image? edit: Yeah, google just keeps on updating. Will look into it.

I am currently investigating this issue as well, because my scripts broke too: https://gf.qytechs.cn/en/forum/discussion/comment/85091/#Comment_85091

Would gladly retire mine if you/we can come up with a solution.

@yakumo_ran said: I am currently investigating this issue as well, because my scripts broke too: https://gf.qytechs.cn/en/forum/discussion/comment/85091/#Comment_85091

Would gladly retire mine if you/we can come up with a solution. Indeed, i had no idea google updated the DOM again. Will update accordingly. Scripts certainly need to bypass selectors(as google updates) and work dynamically using events - in the end.

Thank you, also please consider changing the way you match an image search:

// @include  https://www.google.com/search?*

// @include  https://www.google.tld/*tbm=isch*

It should be .tld for any toplevel domain, so non-english google.cl and alike will work. It should contain tbm=isch and not search, so it only injects in image searches and not web searches.

I tested your script and it works amazing on the new design! However you removed your code for the old design, for which I run two scripts now (my old light and your new with jquery). Totally acceptable for myself.

Suggesting if you could instead render the direct link over the image as in this outdated script of mine: https://gf.qytechs.cn/en/scripts/388820-google-images-direct-links-2019-disable-sidebar-jquery/code

And keep a backwards compatibility for the old design as in my other (outdated) script: https://gf.qytechs.cn/en/scripts/388792-google-images-direct-links-2019-disable-sidebar-light/code

With that it would be downright perfect. I possibly could piece together such a script myself, but I'm not really a webdeveloper. Right now what Google does is really bad for users, since you may never know which DOM will load for them randomly. Right now I just want someone to have a perfect script so I can shut down my old projects.

@yakumo_ran said: Thank you, also please consider changing the way you match an image search:

// @include  https://www.google.com/search?*

// @include  https://www.google.tld/*tbm=isch*

It should be .tld for any toplevel domain, so non-english google.cl and alike will work. It should contain tbm=isch and not search, so it only injects in image searches and not web searches.

I tested your script and it works amazing on the new design! However you removed your code for the old design, for which I run two scripts now (my old light and your new with jquery). Totally acceptable for myself.

Suggesting if you could instead render the direct link over the image as in this outdated script of mine: https://gf.qytechs.cn/en/scripts/388820-google-images-direct-links-2019-disable-sidebar-jquery/code

And keep a backwards compatibility for the old design as in my other (outdated) script: https://gf.qytechs.cn/en/scripts/388792-google-images-direct-links-2019-disable-sidebar-light/code

With that it would be downright perfect. I possibly could piece together such a script myself, but I'm not really a webdeveloper. Right now what Google does is really bad for users, since you may never know which DOM will load for them randomly. Right now I just want someone to have a perfect script so I can shut down my old projects. I'm no web developer myself. Thanks for the tips especially the regex, highly appreciated, will do in the next update.